[stable5.7] fix: correct favorite/unfavorite bulk action logic#12908
Open
backportbot[bot] wants to merge 1 commit intostable5.7from
Open
[stable5.7] fix: correct favorite/unfavorite bulk action logic#12908backportbot[bot] wants to merge 1 commit intostable5.7from
backportbot[bot] wants to merge 1 commit intostable5.7from
Conversation
The unfavorite button called favoriteAll() and vice versa, with favFlags computed via negated 'isAtLeastOneSelected*' checks. When all selected messages shared the same state, the flag was inverted, causing a no-op or the wrong action. Replace with explicit favFlag: true/false and correctly named methods. Fixes #12149 Signed-off-by: RobinAngele <robin@robin4consulting.com>
backportbot
Bot
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #12899